991: post-review.py does not trim whitespace before comparing a string in diff
- Duplicate
- Review Board
| bengc******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| March 28, 2009 | |
at line 1486, in def diff(self, args):
if len(dl) == 1 and \
dl[0] == ('Files %s and %s differ'% (old_file, new_file)):
While using with Perforce, dl[0] appears to have a whitespace. This causes
the string comparison failed.
Proposed solution:
if len(dl) == 1 and \
string.strip(dl[0]) == ('Files %s and %s differ'% (old_file,
new_file)):
