958: Changes to Testing Done section lost when navigating between Diff and Review views
- UnableToReproduce
- Review Board
| yan***@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Sept. 1, 2009 |
What's the URL of the page containing the problem? https://reviewboard.eng.vmware.com/r/66161/diff/ What steps will reproduce the problem? 1. post-review an updated version of a changelist 1. Edit the testing done section of the review while on the diff view page 2. Click OK to save the new content 3. Click 'view reviews' to go the review view page to double check something prior to publishing the updated diff What is the expected output? What do you see instead? I expected to see the new content I spent 20 minutes typing up, instead the content displayed has reverted to the previous one sentence version that I replaced. What operating system are you using? What browser? linux, FF 2.0.0.17 Please provide any additional information below.
Shift-reload, make sure your browser isn't caching something. We *do* save to the database. So I don't know why it would be lost. Does this happen only when starting changes on the diff viewer page?
-
+ NeedInfo
I think I have noticed this several times, in the past week or two, but it wasn't until today that I was 100% positive that I had in fact clicked the 'OK' button to save my change first. When text gets dropped, I usually just blame myself for forgetting to click all the necessary OK buttons, but I know I did that this time, since I only edited one field. I did not try shift-reloading once I went back to the Review view. I'll try that next time. Yes, this only seems to happen when making a change on the diff page, since the version of RB we were using previously didn't even let you edit that field from that page, you *had* to navigate back to the main page.
Uhm sorry, that last part didn't make sense, did it... This only seems to happen when making a change on the diff page. Since the version of RB we were using previously didn't even let you edit that field from the diff page, I had been continuing to go back to the main page to do it. It hasn't been until recently that I've been experimenting with making any changes to the 'top part' (testing done, reviewers, etc)
I can't reproduce this problem. Do you happen to have Firebug installed? Can you reproduce this reliably, and if so, can you see what Firebug says in the console tab?
-
- NeedInfo + Incomplete
This was probably just an overly-aggressive caching thing. I tried to reproduce this just now (internal VMware instance) and nothing was lost. I think this can be closed as unable to reproduce.
-
- Incomplete + UnableToReproduce