954: Download Diff should allow selection of line endings

grossag
board.org/

Describe the enhancement and the motivation for it.
On my Windows machine, if I try to download the diff from review board and
feed it directly in patch, patch fails because it can't handle the Unix
line endings.  I then have to find a unix2dos utility to convert it to dos
line endings.  It would be nice if the Download Diff button could have a
dropdown menu like Close, in this case letting you select Windows or Linux
compatibility.

What operating system are you using? What browser?
Firefox 3 on Windows XP Pro SP3
david
#1 david
  • -Type-Defect
    +Type-Enhancement
jameslin
#2 jameslin
Reviewboard even could pick line-endings automatically based on the user-agent.
david
#3 david
  • +Component-DiffViewer