950: Updating review without changing diff shouldn't make a new diff revision

zhi****@gmai***** (Google Code) (Is this you? Claim this profile.)
March 24, 2009 
board.org/

What's the URL of the page this enhancement relates to, if any?

Any review page.

Describe the enhancement and the motivation for it.

When posting a new review that only changes meta information (the change
description, etc.), but leaves the actual diff unchanged, a new diff
revision shouldn't be created.

The current behavior seems to be to create a new diff revision that's
exactly identical to the previous revision.

This would be nice since it would reduce the number of revisions to click
through to looks for substantial changes in an updated review.

What operating system are you using? What browser?

Windows 2008, 64-bit, Firefox 3.0.7.

Please provide any additional information below.
david
#1 david 
Every time you post-review, it's a new diff, whether or not you've actually changed
the code. If you just want to update the description, do that on the web UI or make
it clear in your update message that you don't need people to look at the diff again.
  • +WontFix
chipx86
#2 chipx86 
If this is due to using post-review with Perforce to re-grab the description, etc.,
you can use --change-only.