933: Clicking expand triggers review comment

jeff****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
March 24, 2009
961, 974, 1061 
Clicking "expand" causes a review dialog to pop up as well as correctly 
expanding the code.

This is the 3.2.09 nightly we're working with.
grossag
#1 grossag 
Saw this too.  Kind of a pain.
grossag
#2 grossag 
Also wanted to mention that this may be related to another issue I see, which is that
after dismissing a review comments, clicking on whitespace in diff text will
sometimes also trigger a review comment...maybe about 50% of the time.  I don't have
the exact repro steps figured out.
chipx86
#3 chipx86
chipx86
#4 chipx86
chipx86
#5 chipx86
  • +Confirmed
  • -Priority-Medium
    +Priority-Critical
    +Milestone-Release1.0
    +Component-DiffViewer
  • +chipx86
#6 cla****@gmai***** (Google Code) (Is this you? Claim this profile.) 
For the record, I liked the old behavior that only clicking or drag-selecting in the 
line number column triggers a comment box.
#7 jeff****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I agree.  I like highlighting blocks by click and dragging text when I'm showing 
something to people (or myself.)
chipx86
#8 chipx86 
Yes, that's why it's a bug :) This was a regression due to a different fix.
chipx86
#9 chipx86 
Fixed in r1848.
  • -Confirmed
    +Fixed
chipx86
#10 chipx86