932: Dashboard does not validate to xhtml specification

onkar******@gmai***** (Google Code) (Is this you? Claim this profile.)
March 25, 2009 
Currently dashboard has too many (50+) errors regarding xhtml validation
(as reported by html validator extension for firefox). Most of these errors
are due to a small error in djblets.
Since I don't know where to send patch regarding djblets, I am attach the
patch here.
xhtml_fix.patch 
Index: reviewboard/templates/reviews/dashboard.html
===================================================================
--- reviewboard/templates/reviews/dashboard.html	(revision 1804)
+++ reviewboard/templates/reviews/dashboard.html	(working copy)
@@ -45,8 +45,8 @@
 {%  for g in user.get_profile.starred_groups.all %}
 {%   dashboard_entry "sub-item" g.name "to-group" g %}
 {%  endfor %}
+{% endifnotequal %}
   </tbody>
-{% endifnotequal %}
  </table>
  <div id="dashboard-main" class="clearfix">
 {{datagrid.render_listview}}
Index: reviewboard/djblets/datagrid/templates/datagrid/listview.html
===================================================================
--- reviewboard/djblets/datagrid/templates/datagrid/listview.html	(revision 11999)
+++ reviewboard/djblets/datagrid/templates/datagrid/listview.html	(working copy)
@@ -43,6 +43,8 @@
     <img src="{{column.image_url}}" width="{{column.image_width}}" height="{{column.image_height}}" alt="{{column.image_alt}}" />
 {%   endif %}
david
#1 david 
Please post any patches to our review board server at http://reviews.review-board.org/
chipx86
#2 chipx86 
This was fixed a while back, but never closed.
  • +Fixed
  • +Milestone-Release1.0
    +Djblets
#3 onkar******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Can you please tell me in which revision was this closed?
#4 onkar******@gmai***** (Google Code) (Is this you? Claim this profile.) 
This bug is not fixed please reopen it.
chipx86
#5 chipx86 
My apologies. I thought this was a different XHTML brokenness patch that was
committed a while ago and we just didn't close this out.

Fixed in Djblets r12004 and Review Board r1860.