915: js file could not be opened - error that it is a binary file appears
- Incomplete
- Review Board
| galia.*******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Sept. 1, 2009 |
What's the URL of the page containing the problem? https://reviewboard.eng.vmware.com/r/63813/diff/2/ What steps will reproduce the problem? 1. Try to open diff 2. js file cannot be reviewed because the next error appears - "This is a binary file. The content cannot be displayed." What is the expected output? What do you see instead? What operating system are you using? What browser? FF 3.0.6 Please provide any additional information below.
Check your diff and see how the file is represented. We only display that error if we're told in the diff that it's a binary file.
-
+ NeedInfo
I have downloaded diff file and when I opened it, its content was the next: Index: VSO-WebViewEngine/context/WEB-INF/system/resources/js/vmo/widget/TabContainer.js ===================================================================
Fortunately there's no code there, but be careful not to put any proprietary content at all on this issue tracker. It's public and anyone can see it. Rather than looking at the downloaded file, can you actually generate a diff using either p5 diff or 'post-review --output-diff' (depending on which you used for Review Board) and e-mail me (christian@...) ?
-
- NeedInfo + Incomplete