899: Perforce error handling problem

eric****@gmai***** (Google Code) (Is this you? Claim this profile.)
March 25, 2009
710
I had an issue where I did not have a p4 ticket (I set the username and
password to blank in my config), and it failed in an unclear way.

The problem is that the P4Error exception API has changed.  It now takes
two arguments.  Line 102 in perforce.py needs to change.  Additionally, as
it is written now, it ignores the first line, but I do not think that is
correct.  In my case, the p4 command only printed 1 line:
'Perforce password (P4PASSWD) invalid or unset.'

I think changing that line to something like this would be helpful:

raise P4Error('P4 command failed:', error)