892: Diff-viewer crash when viewing difference between diffs with new files.
- Fixed
- Review Board
| eduardo********@gmai***** (Google Code) (Is this you? Claim this profile.) | |
 |
|
| Feb. 26, 2009 | |
| 896, 901, 917, 925, 968 |
What's the URL of the page containing the problem?
/r/11/diff/2-3/#index_header
What steps will reproduce the problem?
1. Create new files and post the review of them
2. Update the diff.
3. Request to see what changes between diffs.
What is the expected output? What do you see instead?
A page containing the difference between two diffs.
I see this error:
list index out of range
Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha4-
py2.4.egg/reviewboard/diffviewer/views.py", line 145, in view_diff
interdiffset, highlighting, True)[0]
IndexError: list index out of range
What operating system are you using? What browser?
MacOS X. Firefox 3.0.6
alternatively, I get a paginator for 2 empty pages.
-
+ Started -
- Priority-Medium + Priority-Critical + Milestone-Release1.0 + Component-DiffViewer -
+ chipx86
Should be fixed in r1800. I'd appreciate it if people could test tonight's nightly and let me know if this fixes the issues in real-world situations.
-
- Started + Fixed
I've tested and it seemed to work at first. But now a problem happens when there's a mixed review, with new files, and existing files. The diff viewer can't find the existing files (which is the opposite of what was happening before). The error I get is: Diff currently unavailable. Error: Internal error. Unable to locate file record for filediff 212
Was this last night's build? (20090228) This should be fixed. The fix for this was committed after the fix for this bug.
Oh, my mistake. I updated to the latest nightly and indeed it is fixed. Sorry for the trouble.