876: Expand All not showing up

bryan*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 10, 2009
I've noticed that the global "Expand Changes" doesn't seem to show up in
alpha 2. My current work-around for the issue is to take the "if else
endif" block out of line 184 to 188 in view_diff.html. I don't know about
most people, but I seem to be fine with having both "Expand changes" and 
"Collapse changes" visible at the same time.

What is the expected output? What do you see instead?
Expand changes when viewing "http://reviewboard/r/17/diff/?collapse=1"

I don't see any expand at all except for the individual diff sections

What operating system are you using? What browser?
Ubuntu 8.10. Firefox 3.0.5
#1 bryan*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Uh by taking it out I just mean the if else endif part. Kinda like this

<ul class="controls">
<!-- {% if collapseall %} -->

<!-- {% else %} -->
 <li><a href=".?expand=1"><img
src="{{MEDIA_URL}}rb/images/expand.png?{{MEDIA_SERIAL}}" width="14" height="14"
border="0" alt="" /> {\
% trans "Expand changes" %}</a></li>


 <li><a href=".?collapse=1"><img
src="{{MEDIA_URL}}rb/images/collapse.png?{{MEDIA_SERIAL}}" width="14" height="14"
border="0" alt="" \
/> {% trans "Collapse changes" %}</a></li>
<!-- {% endif %} -->
</ul>
chipx86
#2 chipx86
Already fixed in SVN.
  • +Fixed