871: post-review script needs to be updated

mfo***@vmwar***** (Google Code) (Is this you? Claim this profile.)
March 24, 2009 
What's the URL of the page containing the problem?
NA. This is a problem with the post-review script for Mac OSX

What steps will reproduce the problem?
1. run post-review {perforce changelist number}
2.
3.

What is the expected output? What do you see instead?
Expected to have the review, with pertinent diffs, posted to the reviewboard. Instead got:

Unable to access https://reviewboard.eng.vmware.com/api/json/reviewrequests/new/. The host 
path may be invalid
HTTP Error 500: Internal Server Error


The correct version of post-review was used:
mforte$ which post-review
post-review is /build/trees/bin/post-review

Mounted file systems were correct:
mforte$ mount
build-toolchain.eng.vmware.com:/toolchain on /private/var/automount/build/toolchain 
(automounted)
scm-trees.eng.vmware.com:/trees on /private/var/automount/build/trees (automounted)


What operating system are you using? Mac OSX 10.4.11

What browser? Safari, although browser is not relevant for this problem


Please provide any additional information below.
david
#1 david 
Can you run post-review with -d and post the results here?
  • +NeedInfo
#2 mfo***@vmwar***** (Google Code) (Is this you? Claim this profile.) 
Here are the results of post-review -d

/Library/WebServer/Documents/toptrack mforte$ post-review -d 126894
>>> Repository path 'perforce-qa.eng.vmware.com:1666'
>>> Attempting to create review request for 126894
>>> HTTP POSTing to /api/json/reviewrequests/new/: {'changenum': '126894', 'repository_path': 'perforce-
qa.eng.vmware.com:1666'}
>>> HTTP Error 500: Internal Server Error
Unable to access https://reviewboard.eng.vmware.com/api/json/reviewrequests/new/. The host path may be 
invalid
HTTP Error 500: Internal Server Error
david
#3 david 
These were some incidental bugs which have since been fixed.
  • -NeedInfo
    +Fixed