857: Cannot create new review request.

dhans*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 9, 2009
What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. I generated diff file using p5 diff -du -c 1266456 >c:\diff
2. adding it to review board is throwing errors
3. I am not sure why this is happening , In the Perforce , I can see the
diff against perforce version

What is the expected output? What do you see instead?


What operating system are you using? What browser?

Browser : Firefox , OS : Win 2003
Please provide any additional information below.


I see this error message

Diff revision 4 (Latest)
Jump to revision: 	
1 2 3 4
Changes between r4 and: 	
1 2 3 4

Files Changed:

1.
//depot/Proj/qa/qa/DTD/DTDLIB/Launchers/ESX/StorageJava/HostRebootWithIoLauncher.pm:Diff
currently unavailable.

    * Collapse changes

//depot/Proj/qa/qa/DTD/DTDLIB/Launchers/ESX/StorageJava/HostRebootWithIoLauncher.pm
Revision 1 	New Change
Diff currently unavailable.
Error: The patch to
'C:/source/vmware/dtd/DTDLIB/Launchers/ESX/StorageJava/HostRebootWithIoLauncher.pm'
didn't apply cleanly. The temporary files have been left in
'/tmp/reviewboard.5QF01y' for debugging purposes. `patch` returned:
patching file /tmp/reviewboard.5QF01y/tmpxz-GS6 patch: **** malformed patch
at line 368: - 'name' => 'failover',
Details

Traceback (most recent call last):
  File
"/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha2-py2.4.egg/reviewboard/diffviewer/views.py",
line 183, in view_diff_fragment
    file = get_requested_diff_file()
  File
"/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha2-py2.4.egg/reviewboard/diffviewer/views.py",
line 159, in get_requested_diff_file
    get_chunks)
  File
"/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha2-py2.4.egg/reviewboard/diffviewer/diffutils.py",
line 613, in get_diff_files
    large_data=True)
  File
"/usr/lib/python2.4/site-packages/Djblets-0.5alpha2-py2.4.egg/djblets/util/misc.py",
line 143, in cache_memoize
    data = lookup_callable()
  File
"/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha2-py2.4.egg/reviewboard/diffviewer/diffutils.py",
line 612, in <lambda>
    enable_syntax_highlighting),
  File
"/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha2-py2.4.egg/reviewboard/diffviewer/diffutils.py",
line 342, in get_chunks
    new = get_patched_file(old, filediff)
  File
"/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha2-py2.4.egg/reviewboard/diffviewer/diffutils.py",
line 258, in get_patched_file
    return patch(filediff.diff, buffer, filediff.dest_file)
  File
"/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha2-py2.4.egg/reviewboard/diffviewer/diffutils.py",
line 124, in patch
    raise Exception(_("The patch to '%s' didn't apply cleanly. The
temporary " +
Exception: The patch to
'C:/source/vmware/dtd/DTDLIB/Launchers/ESX/StorageJava/HostRebootWithIoLauncher.pm'
didn't apply cleanly. The temporary files have been left in
'/tmp/reviewboard.5QF01y' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.5QF01y/tmpxz-GS6
patch: **** malformed patch at line 368: -            'name' => 'failover',



1.
//depot/Proj/qa/qa/DTD/DTDLIB/Launchers/ESX/StorageJava/HostRebootWithIoLauncher.pm:Diff
currently unavailable.
chipx86
#1 chipx86
Can you e-mail me the patch directly (christian@). I'll take a look at it.

I recommend trying post-review, see if that makes a difference.
  • +NeedInfo
#2 dhans*****@gmai***** (Google Code) (Is this you? Claim this profile.)
ya i recreated all steps and it worked fine.
not sure if it was p5 diff issue.
chipx86
#3 chipx86
  • -NeedInfo
    +UnableToReproduce