851: RFE: Commit-It

kbi***@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 28, 2009 
User story:

As a reviewer, I need to be able to set different kinds of status on a
review - Ship-it and commit-it in our case so that we can track two
different levels of authorization - one from peers, one from QA.  Commit-it
is when a patch is deemed ready for commit to source control but has not
been QA reviewed.  Ship-it would mean that QA has reviewed the code and
deems it ready for production release.  The labels were chosen by others in
my company.  Personally, I prefer review?/+/- and approve?/+/- just like
with Bugzilla.
david
#1 david
  • -Type-Defect
    +Type-Enhancement
david
#2 david 
Actually, I think you should just use your words. I don't understand your workflow,
but it seems odd that QA would be reviewing the code instead of testing the change
itself.
  • +WontFix
#3 kbc****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Not having commit-it makes it difficult to search specifically on that status.  That makes it 
harder for QA to participate in the review process.  There are also cases where code needs 
to be reviewed by two levles of reviewers like code that interacts with the database needs 
develdeveloper review and DBA review.  There is little point in bothering a DBA with a 
review that won't pass peer review.