84: windows compatibility: popen2.Popen3 not available in windows
- Fixed
- Review Board
| ssal****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
 |
|
| June 2, 2007 |
patch/lsdiff are launched using Popen3 which is not available in windows (diffutils.py/parser.py).
I had the same problem, but it is quite simple to fix it.
Index: parser.py
===================================================================
--- parser.py (revision 636)
+++ parser.py (working copy)
@@ -1,5 +1,5 @@
import re
-from popen2 import Popen3
+import popen2
class File:
def __init__(self):
@@ -84,7 +84,7 @@
files.append(newfileinfo)
- p = Popen3('lsdiff -n')
+ p = popen2.Popen3('lsdiff -n')
p.tochild.write(data)
p.tochild.close()
r = p.fromchild.read().strip()
Working on replacing it with the new subprocess module, which is implemented on all platforms.
-
+ Started -
+ david