What's the URL of the page this enhancement relates to, if any?
View Differences screen
Describe the enhancement and the motivation for it.
When Perforce goes down behind your back, it is not obvious why you are
getting a Python dump. A better error would be useful to the end users
who may or may not know the state of Perforce when trying to add comments
to existing reviews.
What operating system are you using? What browser?
Server: Ubuntu
Browser: IE7
Please provide any additional information below.
Full Dump (note no mention of the actual problem)
__init__() takes exactly 3 arguments (2 given)
Traceback (most recent call last):
File "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081203-
py2.5.egg/reviewboard/diffviewer/views.py", line 86, in view_diff
files = get_diff_files(diffset, None, interdiffset, highlighting)
File "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081203-
py2.5.egg/reviewboard/diffviewer/diffutils.py", line 654, in get_diff_files
enable_syntax_highlighting)
File "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081203-
py2.5.egg/reviewboard/diffviewer/diffutils.py", line 573, in generate_files
large_data=True)
File "/usr/lib/python2.5/site-packages/Djblets-0.4.dev_20081204-
py2.5.egg/djblets/util/misc.py", line 142, in cache_memoize
data = lookup_callable()
File "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081203-
py2.5.egg/reviewboard/diffviewer/diffutils.py", line 572, in <lambda>
enable_syntax_highlighting),
File "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081203-
py2.5.egg/reviewboard/diffviewer/diffutils.py", line 338, in get_chunks
old = get_original_file(filediff)
File "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081203-
py2.5.egg/reviewboard/diffviewer/diffutils.py", line 245, in
get_original_file
large_data=True)[0]
File "/usr/lib/python2.5/site-packages/Djblets-0.4.dev_20081204-
py2.5.egg/djblets/util/misc.py", line 142, in cache_memoize
data = lookup_callable()
File "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081203-
py2.5.egg/reviewboard/diffviewer/diffutils.py", line 244, in <lambda>
data = cache_memoize(key, lambda: [fetch_file(file, revision)],
File "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081203-
py2.5.egg/reviewboard/diffviewer/diffutils.py", line 224, in fetch_file
data = tool.get_file(file, revision)
File "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081203-
py2.5.egg/reviewboard/scmtools/perforce.py", line 93, in get_file
raise P4Error('\n'.join(line[1:] for line in error[1:]))
TypeError: __init__() takes exactly 3 arguments (2 given)
