816: Adding a review from a directory other than where the file to review exists cause error.

perif*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 5, 2009 
What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. create a review from a directory other than where the file to be
reviewed exists
review-request ~/abc/def/file.pl

2. Once you submit the review, I get the following error. 

The current directory does not contain a checkout from a
supported source code repository

3.

What is the expected output? What do you see instead?

What operating system are you using? What browser?
this is on CentOS 4 i386

Please provide any additional information below.
Looks like post-review uses the current directory to figure out what SCM
tool to be used rather than the destination directory.
chipx86
#1 chipx86 
This is intentional. You need to be in the right directory for this to work so that
we can figure out certain things and get the paths right. It's unlikely we'll change
this.

Is there a reason this is proving to be problematic?
  • +NeedInfo
#2 perif*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Not really problematic. If this is intentional, maybe the error message could be more
useful. Currently it isn't very clear what the reason for failure really is.
Also, having used review board for a short period of time, I'm wondering if it
supports adding multiple files to a review. For example, I want to create a review
with fileA and fileB. If this is supported but the 2 files are in different
directories, how would this limitation overcome such issues.
chipx86
#3 chipx86 
Generally, assuming you have one change per repository, you should just run
"post-review". It will look at all modified files. This is the common way to use it.
You can, however, specify all the files individually.

So we should make this bug about informing the user if they're in the wrong directory.
  • -NeedInfo
    +Confirmed
  • -Type-Defect
    -Priority-Medium
    +Type-Enhancement
    +Priority-Low
    +Component-Scripts
#4 perif*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
i suppose you could. however if would be really nice if it just worked. I'll leave it
upto you. I guess no one else has complained about this yet.
david
#5 david 
post-review with SVN can take file arguments now, even for remote repositories. I'm
hoping this satisfies all your requirements.
  • -Confirmed
    +Fixed