814: Context diffs are missing filename information in "Download Patch"

bhaves*******@gmai***** (Google Code) (Is this you? Claim this profile.)
March 25, 2009 
What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. "Download patch" for any reviewboard review request
2. View the patch: there are no filenames referenced in the patch.
3.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.
chipx86
#1 chipx86 
What revision control system are you using? How did you upload the patch?
  • +NeedInfo
#2 bhaves*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
perforce at vmware. I didn't:

https://reviewboard.eng.vmware.com/r/55191/
#3 onkar******@gmai***** (Google Code) (Is this you? Claim this profile.) 
1. Do you mean to say that the file does not include any header at all indicating
which files were changed?
OR
2. Do you mean to say that when the file is fed to patch it fails to apply?

If you are talking about 1, then I haven't seen this problem yet.
If you are talking about 2 then this is because the patch contains the depot patch of
the files not local path. You will need to find out correct option to be passed to
patch (-pn) for the patch to apply successfully.
#4 bhaves*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Both 1 & 2. Here's how the downloaded patch starts (first few lines):

-----------snip------------
5a6,15
> 
> /*
-----------snip------------

So no header indicating which files were changed, and therefore patch is unhappy with
the patch.

Yes, I was expecting something similar to a "p4 diff -u ..." patch from reviewboard.
chipx86
#5 chipx86 
This was due to the diff being uploaded as a context diff. Perhaps we're parsing it
wrong or something, but this should be uploaded as a unified diff. I'll look into why
the context diff wasn't being parsed correctly. However, you may want to ask the
submitter to use unified diffs from now on, or ideally to use post-review.
  • -NeedInfo
    +Confirmed
  • +Component-DiffParser
  • +Context diffs are missing filename information in "Download Patch"
chipx86
#6 chipx86 
I looked into this a bit, and we really don't fully support context diffs. Unified
diffs are pretty much required.
  • -Confirmed
    +WontFix