812: Crash on reviews with a trophy

francois********@eures****** (Google Code) (Is this you? Claim this profile.)
Jan. 29, 2009
What's the URL of the page containing the problem?
 http://reviewboard.server.name/r/3223/
 or any url to a review whose number is a palindrome.

What steps will reproduce the problem?
1. Visit a review whose number is a palindrome

What is the expected output? What do you see instead?
 It should display the review with a trophy at the top of the page. Instead
we get this error:


TemplateSyntaxError at /r/3223/

Caught an exception while rendering: u'review_request.id'

Original Traceback (most recent call last):
  File
"/homedir/rbpython/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/django/template/debug.py",
line 71, in render_node
    result = node.render(context)
  File
"/homedir/rbpython/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/django/templatetags/i18n.py",
line 85, in render
    data = dict([(v, force_unicode(context[v])) for v in vars])
  File
"/homedir/rbpython/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/django/template/context.py",
line 43, in __getitem__
    raise KeyError(key)
KeyError: u'review_request.id'

Request Method: 	GET
Request URL: 	http://reviewboard.servername.somewhere/r/3223/
Exception Type: 	TemplateSyntaxError
Exception Value: 	

Caught an exception while rendering: u'review_request.id'

Original Traceback (most recent call last):
  File
"/homedir/rbpython/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/django/template/debug.py",
line 71, in render_node
    result = node.render(context)
  File
"/homedir/rbpython/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/django/templatetags/i18n.py",
line 85, in render
    data = dict([(v, force_unicode(context[v])) for v in vars])
  File
"/homedir/rbpython/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/django/template/context.py",
line 43, in __getitem__
    raise KeyError(key)
KeyError: u'review_request.id'

Exception Location: 
/homedir/rbpython/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/django/template/debug.py
in render_node, line 81
Python Executable: 	/usr/bin/python
Python Version: 	2.4.4
Python Path: 
['/homedir/rbpython/lib/python2.4/site-packages/setuptools-0.6c8-py2.4.egg', '/homedir/rbpython/lib/python2.4/site-packages/django_evolution-0.0.0-py2.4.egg',
'/homedir/rbpython/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg',
'/homedir/rbpython/lib/python2.4/site-packages/pysqlite-2.5.1-py2.4-linux-i686.egg',
'/homedir/rbpython/lib/python2.4/site-packages/PIL-1.1.6-py2.4-linux-i686.egg',
'/homedir/rbpython/lib/python2.4/site-packages/ReviewBoard-0.9.dev_20090113-py2.4.egg',
'/homedir/rbpython/lib/python2.4/site-packages/Djblets-0.4.dev_20090113-py2.4.egg',
'/var/www/reviewboard/conf', '/homedir/rbpython/bin',
'/usr/lib/python24.zip', '/usr/lib/python2.4',
'/usr/lib/python2.4/plat-linux2', '/usr/lib/python2.4/lib-tk',
'/usr/lib/python2.4/lib-dynload', '/usr/local/lib/python2.4/site-packages',
'/usr/lib/python2.4/site-packages', '/usr/lib/python2.4/site-packages/PIL',
'/var/lib/python-support/python2.4',
'/homedir/rbpython/lib/python2.4/site-packages']
Server time: 	Tue, 13 Jan 2009 01:39:18 -0800
Template error

In template
/homedir/rbpython/lib/python2.4/site-packages/ReviewBoard-0.9.dev_20090113-py2.4.egg/reviewboard/templates/reviews/trophy_box.html,
error at line 9
Caught an exception while rendering: u'review_request.id'
1 	{% load djblets_deco %}
2 	{% load djblets_utils %}
3 	{% load i18n %}
4 	{% load reviewtags %}
5 	
6 	{% ifneatnumber review_request.id %}
7 	{% box "yay" %}
8 	<img src="{{MEDIA_URL}}rb/images/{% if milestone %}trophy{% else
%}fish-trophy{% endif %}.png" width="32" height="48" border="0" alt="" />
9 	<h1>{% blocktrans with review_request.submitter|user_displayname as
submitter %}{{submitter}} got review request #{{review_request.id}}!{%
endblocktrans %}</h1>
10 	{% endbox %}
11 	{% endifneatnumber %}
12 	
13 

The problem has been reproduced with 
ReviewBoard-0.9.dev_20090107-py2.4.egg and
ReviewBoard-0.9.dev_20090113-py2.4.egg
#1 Francois********@gmai***** (Google Code) (Is this you? Claim this profile.)
This has been fixed in http://code.google.com/p/reviewboard/source/detail?r=1671
chipx86
#2 chipx86
  • +Fixed