807: Links from reviews do not link to the corresponding line in the diff properly.
- Fixed
- Review Board
| jeff****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
 |
|
| April 1, 2009 |
What steps will reproduce the problem? 1. Create a review. 2. Comment on a line in the review and publish the draft. The file link, ie: /trunk/hal/micros/lpc2468/include/mac.h (Diff revision 1) links to: http://mycompany.com/r/111/diff/1/?file=1053#file1053line434 Actually, I just noticed the links from RB emails in the form of: <http://mycompany.genie.com/r/111/#comment178> do not properly link either.
By the way, this is severely annoying when you want a little context for the comment, but your diff is HUGE.
A new UI rewrite went in just recently, so there's some things that are still a little broken. This appears to be one of them. We'll get it fixed. As for comments on the review request page, this is due to the progressive loading of the page. Hard to do much about that, but we're looking into it.
-
+ Confirmed -
+ Component-DiffViewer + Component-Reviews -
+ chipx86
Links to diffs might be fixed now. I haven't verified, but this may be related to issue 828.
Just FYI: this fix would not resolve email links not working correctly.
Really? It should solve that. You're still seeing this problem? We're using the same address in the e-mails and on the review page for links (or, we certainly should be, otherwise there's a bug there).
The "<http://mycompany.com/r/111/#comment178>" links (review links) won't be fixed because they're found in the progressive loading section of the review page from what I understand in your comment above. I haven't updated our installation yet to check with linking to lines in the file (file links), and won't be able to until Thursday.
This issue is resolved. Fantastic. Thanks.
I can also confirm this is fixed with 3/13/09 nightly. Thanks!
-
- Confirmed + Fixed -
+ Milestone-Release1.0