805: post-review script fails when using CVS.

onkar******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Jan. 18, 2009
What steps will reproduce the problem?
1. Setup configuration of a CVS repository in review board.
2. Try submitting review for a change in CVS workspace using post-review.

What is the expected output? What do you see instead?
Review should get submitted to the review board server. But instead I see
following error.
Error creating review request: The repository path specified is not in the
list of known repositories (code 206)

What operating system are you using? What browser?
Ubuntu, browser is not relevant.

Please provide any additional information below.
The problem seems to be due to following code at line 655 in post-review.
canon = socket.getfqdn()
The code will return the fqdn of local host. This is wrong. It should use
fqdn of the CVS server.
#1 onkar******@gmai***** (Google Code) (Is this you? Claim this profile.)
The minor patch posted at http://reviews.review-board.org/r/684/
#2 onkar******@gmai***** (Google Code) (Is this you? Claim this profile.)
Oops, the correct url is http://reviews.review-board.org/r/691/
chipx86
#3 chipx86
Thanks. Fixed in r1674.
  • +Fixed
  • -Priority-Medium
    +Priority-High
    +Milestone-Release1.0
    +Component-Scripts
  • +chipx86