797: Reviewboard crash when review assigned to myself and reviewed

nithi******@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 10, 2009
705
What's the URL of the page containing the problem?
Review url

What steps will reproduce the problem?
1. Create a review and assign to yourself.
2. Enter some comment and then publish them.
3. Got a crash.

What is the expected output? What do you see instead?
Used to work before. Now I can't even go and delete it.

MultipleObjectsReturned at /r/910/

get() returned more than one Review -- it returned 2! Lookup parameters
were {'base_reply_to__isnull': True, 'review_request': <ReviewRequest:
Dummy. DONT CHECKIN>, 'user': <User: nsujir>, 'public': False}

Request Method: 	GET
Request URL: 	http://10.220.0.40/r/910/
Exception Type: 	MultipleObjectsReturned
Exception Value: 	

get() returned more than one Review -- it returned 2! Lookup parameters
were {'base_reply_to__isnull': True, 'review_request': <ReviewRequest:
Dummy. DONT CHECKIN>, 'user': <User: nsujir>, 'public': False}

Exception Location: 
/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/db/models/query.py
in get, line 311
Python Executable: 	/usr/bin/python
Python Version: 	2.5.2
Python Path: 	['/var/www/reviewboard/conf',
'/usr/lib/python2.5/site-packages/django_evolution-0.0.0-py2.5.egg',
'/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg',
'/usr/lib/python2.5/site-packages/python_memcached-1.43-py2.5.egg',
'/usr/lib/python2.5/site-packages/JCC-1.9-py2.5-linux-i686.egg',
'/usr/lib/python2.5/site-packages/lucene-2.3.2-py2.5-linux-i686.egg',
'/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20090103-py2.5.egg',
'/usr/lib/python2.5/site-packages/Djblets-0.4.dev_20090103-py2.5.egg',
'/usr/lib/python2.5', '/usr/lib/python2.5/plat-linux2',
'/usr/lib/python2.5/lib-tk', '/usr/lib/python2.5/lib-dynload',
'/usr/local/lib/python2.5/site-packages',
'/usr/lib/python2.5/site-packages',
'/usr/lib/python2.5/site-packages/Numeric',
'/usr/lib/python2.5/site-packages/PIL',
'/usr/lib/python2.5/site-packages/gst-0.10',
'/var/lib/python-support/python2.5',
'/usr/lib/python2.5/site-packages/gtk-2.0',
'/var/lib/python-support/python2.5/gtk-2.0']
Server time: 	Tue, 6 Jan 2009 15:00:35 +0530


Environment:

Request Method: GET
Request URL: http://10.220.0.40/r/910/
Django Version: 1.0.2 final
Python Version: 2.5.2
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.markup',
 'django.contrib.sites',
 'django.contrib.sessions',
 'djblets.datagrid',
 'djblets.feedview',
 'djblets.siteconfig',
 'djblets.util',
 'djblets.webapi',
 'reviewboard.accounts',
 'reviewboard.admin',
 'reviewboard.changedescs',
 'reviewboard.diffviewer',
 'reviewboard.iphone',
 'reviewboard.reports',
 'reviewboard.reviews',
 'reviewboard.scmtools',
 'reviewboard.webapi',
 'django_evolution']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.middleware.doc.XViewMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'djblets.siteconfig.middleware.SettingsMiddleware',
 'reviewboard.admin.middleware.LoadSettingsMiddleware',
 'djblets.log.middleware.LoggingMiddleware',
 'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')


Traceback:
File
"/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/handlers/base.py"
in get_response
  86.                 response = callback(request, *callback_args,
**callback_kwargs)
File
"/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20090103-py2.5.egg/reviewboard/accounts/decorators.py"
in _check
  27.             return view_func(*args, **kwargs)
File
"/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/views/decorators/cache.py"
in _cache_controlled
  30.             response = viewfunc(request, *args, **kw)
File
"/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20090103-py2.5.egg/reviewboard/reviews/views.py"
in review_detail
  111.     review = review_request.get_pending_review(request.user)
File
"/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20090103-py2.5.egg/reviewboard/reviews/models.py"
in get_pending_review
  355.                                       base_reply_to__isnull=True)
File
"/usr/lib/python2.5/site-packages/Djblets-0.4.dev_20090103-py2.5.egg/djblets/util/misc.py"
in get_object_or_none
  179.         return manager.get(*args, **kwargs)
File
"/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/db/models/manager.py"
in get
  93.         return self.get_query_set().get(*args, **kwargs)
File
"/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/db/models/query.py"
in get
  311.                 % (self.model._meta.object_name, num, kwargs))

Exception Type: MultipleObjectsReturned at /r/910/
Exception Value: get() returned more than one Review -- it returned 2!
Lookup parameters were {'base_reply_to__isnull': True, 'review_request':
<ReviewRequest: Dummy. DONT CHECKIN>, 'user': <User: nsujir>, 'public': False}

What operating system are you using? What browser?

Ubuntu 8.10, Firefox

Please provide any additional information below.
#1 nithi******@gmai***** (Google Code) (Is this you? Claim this profile.)
Also the review email when created had two different link. One had id 910 the other
had id 710

Review Url: http://10.220.0.40/r/710


Diffs
-----
Diff: http://10.220.0.40/r/910/diff