788: "Ship It" is mistakenly added when publishing review comments

young*****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Dec. 31, 2008
The steps to reproduce the problem:
1. Click "View Diff" and add some comments on a review request
2. Click "Edit Review"
3. Click "Publish Review" ("Ship It" is not ticked)

The expected result is the comments are published without showing "Ship
It".  The actual result is the comments are published with "Ship It".

I'm using Windows XP and Firefox 3.0.5.

There is also another way to reproduce this:
1. Click "Review" and add some comments on a review request
2. Click "Publish Review" ("Ship It" is not ticked)

But the "Ship It" won't be mistakenly added if
1. Click "View Diff" and add some comments on a review request
2. Click "Publish"
chipx86
#1 chipx86
Thanks for the report. Fixed in r1656, and will be in the next nightly (generated in
about 30-40 mins).
  • +Fixed
  • -Priority-Medium
    +Priority-Critical
    +Milestone-Release1.0
    +Component-API
  • +chipx86