787: Commenting on comments doesn't work
- Fixed
- Review Board
| alexlod********@gmai***** (Google Code) (Is this you? Claim this profile.) | |
 |
|
| Dec. 31, 2008 | |
| 789 |
Comments made on others' comments cannot be seen by anyone. I would expect there to be a "Publish" comments box that lets me publish the comments I have made, but no box shows up. Repro: Create a new code review on user A. Have user B make comments on arbitrary lines of code. Then have user A comment on user B's comments. Then see if user B can see user A's comments. URL: https://git.cloudera.com/reviewboard/r/X/ Browser: FF3 on Mac Thanks!
Important note for reproducing: when replying to the comment, do so on the Review page, not the Diff page. In the Diff page, replying causes a banner to appear. In the Review page, no such banner is triggered.
I'll give that a shot; thanks!
I'd like to know more what you mean by this. You should never have to reply to a comment on the diff viewer. When you say "banner," what specifically are you referring to? Replying on the diff viewer doesn't reply, it creates a brand new review, which is not what you want. Is the problem that clicking "Add Comment" on the review does nothing? Can you check your JavaScript debug log and see if it produces an error? Also, make sure you upgrade your copy of Djblets and then re-run "rb-site upgrade" on your site.
My steps were: 1. svn update 2. clear server cache and browser cache 3. restart fcgi-wrapped rb server process 4. visit a review request that has a review 5. Click "Add comment", fill in a reply, and hit OK (the reply shows up as editable) At this point, there was nothing to click to publish the reply (it used to be at the top of the replied-to review, as a green-background "publish/discard" banner). I will try running rb-site upgrade (my installation predates rb-site, so I had never used it).
After migrating my installation to use rb-site
(http://code.google.com/p/reviewboard/wiki/GettingStarted#Migrating_Installations -
don't forget to back up your site in case this goes south) and mod_python (instead of
fcgi), I still experience the undesirable behavior described in comment 4.
I'm using Ubuntu 8.10's Firefox 3.0.5 on x86_64. Nothing besides CSS warnings are
reported in the Error Console ("JS debug log").
The following eggs were installed by the install+upgrade procedure (if it helps,
e.g., to diagnose a simple version problem):
Django-1.0.2_final-py2.5.egg
PIL-1.1.6-py2.5-linux-i686.egg
django_evolution-0.0.0-py2.5.egg
ReviewBoard-0.9.dev_r1654-py2.5.egg
Djblets-0.4.dev_20081230-py2.5.egg
alex: in the mean time, a workaround is to revert the single change that introduced
the UI changes; it also works to log in as the admin, use the Database tool to find
the review object representing the reply, and set 'public' to true.
Looks like there was a regression due to another branch's merge that I didn't catch in my active branch. This should now be fixed in r1655, and will be in tonight's nightly (available at about 12:20 AM PST, just under an hour from now). Sorry for the trouble. Please let me know if it's still problematic after tonight's build. Remember to re-run "rb-site upgrade" after upgrading Review Board.
-
+ Fixed -
- Priority-Medium + Priority-Critical + Milestone-Release1.0 + Component-Reviews -
+ chipx86
Thanks, guys! I love the speed of patches here :). Review Board FTW!!!
Issue 789 sounds more like Issue 790 than this one, though I'm not sure.