785: Retrive bugs fixed from 'Jobs' in a p4 changelist

onkar******@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 4, 2014 
http://reviews.review-board.org/

Describe the enhancement and the motivation for it.
*NOTE: Do not post confidential information in this bug report.*

This is a request which might be specific to our setup so let me give some
background.
The way perforce and bugzilla are integrated at my office is as follows.
1. Whenever a bug is reported a job is created in perforce with name of the
format 'bug<bug_number>'.
2. When creating changelist we are expected to specify the jobs that are fixed.
3. When a changelist is submitted the job gets marked as fixed and also the
bug is marked fixed.

So my request is that we make use of this information available in the
changelist in following way.
1. The jobs fixed can be found with command 'p4 fixes -c <changenum>'
2. Retrieve the bugs number from each line by using regular expression
'^bug(\d+).*'
3. Add these bug numbers in a list.
4. Use join function to join the bug numbers with comma (',') as separator.
5. Send this comma separated bug list to server.

I am currently modifying the post-review script to make this work. And if
it works then I will post the diff.
#1 onkar******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Patch posted at http://reviews.review-board.org/r/680/
david
#2 david
  • +Started
  • -Type-Defect
    +Type-Enhancement
    +Component-SCMTools
    +PendingReview
#3 onkar******@gmai***** (Google Code) (Is this you? Claim this profile.) 
For some reason I am not able to add comment on the review. So posting my reply here.

1. I did this change specifically to workaround bug 777. And that is why the change
lies in post-review script.
2. If we decide to move the change to scmtools/perforce.py then we will have to add a
field in perforce repository configuration where user can specify the regular
expression to be used to retrieve the bug numbers from jobs fixed.
david
#4 david
  • -Started
    +WontFix