775: Issues when using Review Board with the "It's All Text" Firefox Extension
- ThirdParty
- Review Board
| eskil******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Dec. 29, 2008 |
What's the URL of the page containing the problem? http://asg-reviews.asglab/r/18/# What steps will reproduce the problem? 1. Create a review. 2. Public the review. 3. Under View Diff, click "Review" and post a comment. 4. On the review page, comment can be seen. 5. Click "Add Comment" What is the expected output? What do you see instead? Displays input field, but there's no save/ok/publish button to be seen on the page. What operating system are you using? What browser? Mac OS 10.5.5 Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-GB; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4 Please provide any additional information below. Attached screenshot of the page.
FF error console shows ;
Error: this.el.dom.value is undefined
Source File: http://asg-reviews.asglab/media/rb/scripts/rb/widgets.js
Line: 456
YAHOO.extendX(RB.widgets.AutosizeTextArea, YAHOO.ext.util.Observable, {
/**
* Auto-sizes this text area to match the content.
*
* This works by setting our proxy element to match the exact width
* of our text area and then filling it with text. The proxy element
* will grow to accommodate the content. We then set our text area
* to the resulting height.
*/
autoSize: function() {
this.el.beginMeasure();
this.proxyEl.setWidth(this.el.getWidth(true));
this.el.endMeasure();
this.proxyEl.moveTo(-10000, -10000);
this.proxyEl.dom.innerHTML =
>>>>> this.el.dom.value.htmlEncode().replace(/[\n]/g, "<br /> ");
this.proxyEl.beginMeasure();
var newHeight = Math.max(this.minHeight,
this.proxyEl.getHeight(true)
+ this.el.getBorderWidth('tb')
+ this.el.getPadding('tb'));
this.proxyEl.endMeasure();
this.el.setHeight(newHeight);
this.fireEvent('resize', this);
}
});
Turns out this is caused by the It's all Text FF plugin (https://addons.mozilla.org/en-US/firefox/addon/4125). Disabling this plugin fixes the problem.
All this code is being replaced by a full rewrite. This will hopefully go in sometime within the next week or two, and should certainly fix this problem. I'm unable to reproduce this with the current codebase. A number of people are using it without problems. I assume this is a brand new install?
Ah, interesting. Okay, good to know. Someone else posted a similar problem with that plugin recently (with a recent version of it -- an older one appeared to be okay). We'll have to document this. Repurposing this bug.
-
+ Confirmed -
+ Milestone-Release1.0 + Browser -
+ Issues when using Review Board with the "It's All Text" Firefox Extension
There's a similar bug on the It's All Text website, where the author recommends turning off the gumdrop. I can confirm that that works. http://trac.gerf.org/itsalltext/ticket/43 At least this way the plugin can still be used with ReviewBoard, which is good, since it makes it much easier to use ReviewBoard.
(oh, and thanks for great tool!)
Fixed in It's All Text 1.2.
Having this problem with It's All Text 1.3.1. Perhaps our Reviewboard version is stale? I am not seeing any way to derive the reviewboard installation version from the UI.
What version does it say on the front page? Or does it just say "beta?" If so, it's *really* old. 1.0 would have this fixed.
OK, we're just megastale then. Sorry to pollute the bug.