772: Lines of all whitespace shouldn't be highlighted in the diff

kyle*****@gmai***** (Google Code) (Is this you? Claim this profile.)
July 27, 2009 
Describe the enhancement and the motivation for it.

Currently, Review Board does not like lines containing all whitespace -
those lines get marked with scary red blocks.  If you use an editor that
does auto-indenting (which I'm sure many people do), then inserting a blank
line (by hitting Enter twice) is going to leave a line with all whitespace.
 I know Review Board marks trailing whitespace in red, but maybe that
should be ignored when the entire line is whitespace?


What operating system are you using? What browser?

Windows XP Professional, Firefox 3
chipx86
#1 chipx86 
While we may be able to make this an optional thing down the road, right now the
current behavior is by design.
#2 kyle*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Sure, that's fine.  If you wanted to add a bit more concreteness to the rule, it
could go something like:

Lines containing all whitespace are OK, as long as the line is not indented further
than the line above.  If the line is indented further than the line above, then those
extra spaces are marked in red.
david
#3 david
  • -Type-Defect
    +Type-Enhancement
  • +Lines of all whitespace shouldn't be highlighted in the diff
david
#4 david 
We have the ability to turn trailing ws off entirely, and we can now toggle
whitespace display at runtime.
  • +Fixed