77: Avoid redundant simultaneous reviews

grant.p********@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 5, 2009
It'd be great if some warning popped up on a review's main page saying
"Hey, somebody's already looking at this review!" To avoid two people
reviewing the same change needlessly. Three pairs of eyes is always better
than two, but in many cases it just isn't necessary, and sometimes
reviewers comment on the same issues.
chipx86
#1 chipx86
  • -Type-Defect
    +Type-Enhancement
    +Component-Reviews
chipx86
#2 chipx86
  • +Milestone-Extensions
    +ExtensionIdea
#3 cybr****@gmai***** (Google Code) (Is this you? Claim this profile.)
I think there needs to be an "Accept" feature. If someone wishes to review a diff,
then they "Accept" the review.

The submitter can see how many people (and who) has accepted the review.

#4 Stefan.B********@gmx**** (Google Code) (Is this you? Claim this profile.)
I support the idea of cybrocop.

An important aspect of this enhancement is that all potential reviewers can see that
other reviewers are already working on a review on this topic.

This helps to avoid two people reviewing the same change needlessly (as grant
patterson pointed out in the initial report).
david
#5 david
After thinking about this for, well, 2 years, I'm going to say that this isn't
something we're going to add in the core, and not an extension that we're going to
write in-house. I'd like to keep the interface as simple and "process-free" as
possible (we already have way too many complicated flows), plus I really don't think
that this scenario is bad from a code-review standpoint. If something is really so
simple that it only needs to be reviewed by one person, it's also short enough that
the possibility of this kind of overlap is really, really tiny and the downside
(repeated work) is also really short.
  • +WontFix