743: Blank Diff Sets

thomas.*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 23, 2008 
I was holding an old install (SVN Checkout and "by hand" settings_local.py)
and tried to update to latest version ...

After some questionning about the brand new easy_install procedure I have a
"working" install of today's build.

The bad thing is that I can't see any File Diff Set anymore. 
I've tried from bot a fresh install and from scratch and even if filling
the fields and uploading the diff set file is OK, when clicking on "View
Diff" ("http://host...."/r/1/diff/#index_header) I get a page with the
reviewboard header, the blue menu bar ... and a empty blank page.


To reproduce
1. New Review Request
2. Upload File Diff Set
3. Click on "View Diff"

What is the expected output? What do you see instead?
A 2 column colored diff / Nothing.

What operating system are you using? What browser?
Using Windows 2000 + local Apache / MySQL and tested with Firefox 3 and IE 6.
chipx86
#1 chipx86 
What did you use to generate the diff? If post-review, try with --output-diff to make
sure there's actual content there.

I can't imagine what would cause this. Certainly haven't seen this issue anywhere
else, so I'll need a lot more information before I can begin to track this down.
  • +Component-DiffViewer
#2 thomas.*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
The diff file was generated with GNU Diff (called by SVN command line). Same diff
with old version of ReviewBoard (let's say mid-October) was working fine.

The very odd thing is that there is no error, simply a blank page.
Included the code of this HTML Page (draft review, uploaded diff set and clicked on
"View Diff").
  • +
    Review_R1.htm 
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
     <head>
      <title> | Diff Viewer | Review Board</title>
      <link rel="icon" type="image/png" href="/media/rb/images/favicon.png" />
      <link rel="stylesheet" type="text/css" href="/media/rb/css/common.css" />
      <script type="text/javascript">
        var MEDIA_URL = "/media/";
    	var SITE_ROOT = "/";
      </script>
    <link rel="stylesheet" type="text/css" href="/media/rb/css/diffviewer.css" />
    <link rel="stylesheet" type="text/css" href="/media/rb/css/reviews.css" />
    <link rel="stylesheet" type="text/css" href="/media/rb/css/syntax.css" />
    <link rel="stylesheet" type="text/css" href="/media/rb/css/yui-ui.css" />
    <style type="text/css">
      .ew { background: #ee3434; }
    </style>
    <script type="text/javascript" src="/media/yui/utilities/utilities.js"></script>
    <script type="text/javascript" src="/media/yui-ext/y
    
 
    

    


    
   
    • 


  


 








 

   

 
 

  

    
     

   
   #3
   thomas.*******@gmai***** (Google Code)



(Is this you? Claim this profile.)


  


  
Still investigating (considering I was hoping to use the tool this week !) ...

Looks like there is something wrong with the diff retreival, same steps with Firebug
raises a JS error :

getEl(gAnchors[anchor]) is null
SetHighlighted(1, true)diffviewer.js (ligne 847)
onPageLoaded(load )diffviewer.js (ligne 456)
(?)()(load )utilities.js (ligne 75)
[Break on this error] var nextNode = getEl(gAnchors[anchor]).getNextSibling();



 








 

   

 
 

  

    
     

   
   #4
   thomas.*******@gmai***** (Google Code)



(Is this you? Claim this profile.)


  


  
Ok, please close this one, root cause was that PatchUtils were not exactly where theu
must be (CygWin/bin).

Maybe it could be useful to add a check for these tools when starting an instance
(maybe only with embedded runserver).



 








 

  

   chipx86

  

 
 

  

    
     

   
   #5
   chipx86


  


  
Yeah, we definitely should do something to validate the install and the dependencies,
making sure everything is in the right place. This is on my TODO for after 1.0.



  
    


   
  • 
    
    
    +UserError
    
   
    •