74: Need a way to update diff without clobbering other fields
- Fixed
- Review Board
ads****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
|
|
June 1, 2007 |
What steps will reproduce the problem? 1. Create a Perforce changeset containing a code change and run post-review on it. 2. Edit a field (e.g. "testing done") in the review request on the web. 3. Make a change to the code and rerun post-review. What is the expected output? What do you see instead? I expect the diff to be updated, which it is, but the other fields get clobbered by the content in the changeset data file. What operating system are you using? What browser? Ubuntu Feisty and Firefox 2.0.0.3
I added a --diff-only flag to post-review which will update existing review requests but avoid copying over changelist information. You'll either have to grab your own copy or wait until Christian updates the common version.
-
- Started + Fixed
I too got bitten by post-review clobbering the "Testing Done" field. It seems to me that --diff-only should be the default behavior.