738: Why does reviewboard use so much memory

pos****@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 28, 2008 
What's the URL of the page containing the problem?
viewing a diff

What steps will reproduce the problem?
1. Create a pretty large diff
2.
3.

What is the expected output? What do you see instead?

I intend it to use on the order of hundreds of megs, instead it uses around 
1.5 gigs.
What operating system are you using? What browser?


Please provide any additional information below.
#1 pos****@gmai***** (Google Code) (Is this you? Claim this profile.) 
It looks like when the ulimit is hit the process spikes cpu and gets in a brk/mmap 
loop

brk(0x2060e000)                         = 0x205ed000
mmap(NULL, 1048576, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 
0x2b9ab0e02000

Why its trying to allocate a gig of memory is beyond me.
chipx86
#2 chipx86 
That seems excessively high. What are you using for Review Board? fastcgi? mod_python?

How big a diff are we talking, both in terms of file size and number of files?
  • +NeedInfo
#3 pos****@gmai***** (Google Code) (Is this you? Claim this profile.) 
It is fastcgi its about 15 files in a reverse integration.
chipx86
#4 chipx86 
We've found that fastcgi has some major memory leak issues when used with Review
Board. We strongly recommend mod_python. We've hit issues in 5 separate installs now
with fastcgi where it would balloon out of control. We now using mod_python and we're
not seeing any of these problems anymore.
david
#5 david
  • -NeedInfo
    +ThirdParty
#6 pos****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Due to heavy useupgrading the reviewboard server takes a while, but I will update this review when we do.