724: post-review - base_path not filled in with git svn report

jane****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Dec. 31, 2008
On my git-svn repository I get following error when using post-review -d:

Error uploading diff: One or more fields had errors (105)
>>> {'fields': {'basedir': ['This field is required.']}, 'stat': 'fail',
'err': {'msg': 'One or more fields had errors', 'code': 105}}

This can be fixed by modifying line 1145

    base_path = m.group(1)[len(path):]

to be the same as line 627 (SVNClient):

    base_path = m.group(1)[len(path):] or "/"
chipx86
#1 chipx86
  • +Confirmed
  • +Milestone-Release1.0
    +Component-Scripts
chipx86
#2 chipx86
Fixed in r1658.
  • -Confirmed
    +Fixed
  • +chipx86