72: Should the "Close" button in the comment dialog be "Cancel"?
- Fixed
- Review Board
| jameslin | |
| Aug. 6, 2007 |
What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below.
Argh, I accidentally hit the Enter key while I was in the middle of typing the subject. And silly Google Code doesn't even let me throw this bug away and let me start over. Well. Anyway. The bug I intended to file was: Should the "Close" button in the comment dialog be "Cancel"? The behavior of the "Close" button is slightly ambiguous. Will it automatically save what I typed? Will it prompt me? Currently it just discards the comment, so I think it might as well be "Cancel". Also, the "X" button in the upper-right corner behaves slightly differently from "Close". It throws away what I've typed, but the marker next to the line number that indicates there's an associated comment doesn't disappear.
Oh, right, the "Close" button is necessary since you need a button to dismiss the comment dialog after you've saved a comment (and clearly "Cancel" there would be very inappropriate). Hm. Maybe the buttons should be different when you're editing and when you're not? I'm not sure. I guess I should think about this some more.
-
+ Should the "Close" button in the comment dialog be "Cancel"?
-
+ Component-DiffViewer
'Close' is bad text for this. I can't tell you how many times i've clicked on 'close' and realized that it didnt save my comment. Can you call it 'cancel', to reflect that its not going to save anything?
I think I have this down now. We show Cancel if you have a comment field open, Close otherwise. We'll see what people think for now.
-
+ Fixed -
- Should the "Close" button in the comment dialog be "Cancel"? + Should the "Close" button in the comment dialog be "Cancel"?