704: LDAP typo: ldapy -> ldap

m.be****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Oct. 21, 2008 
What's the URL of the page containing the problem?
http://review.tor.rapid7.com/admin/settings/general/

What steps will reproduce the problem?
1. Install python-ldap
2. Restart the Review Board server
3. In the settings page, select LDAP as the "Authentication Method"
4. The page displays "LDAP authentication requires the python-ldap library,
which is not installed."

What is the expected output? What do you see instead?
The page should not display the above error message, but should allow the
enduser to configure the other LDAP options.

The problem is caused by apparently a typo. The attached patch fixes it and
fixed the pb for me.
fix-ldapy-typo.patch 
Index: admin/checks.py
===================================================================
--- admin/checks.py	(revision 1541)
+++ admin/checks.py	(working copy)
@@ -109,7 +109,7 @@
     Checks whether LDAP authentication can be enabled.
     """
     try:
-        imp.find_module("ldapy")
+        imp.find_module("ldap")
         return (True, None)
     except ImportError:
         return (False, _(
chipx86
#1 chipx86 
Thanks, fixed in r1542.

In the future, please submit patches to http://reviews.review-board.org/, as that'll
help us keep track of the status of the patches and handle reviews.
  • +Fixed
  • -Priority-Medium
    +Priority-Critical
    +Milestone-Release1.0
    +Component-Accounts
  • +chipx86
#2 m.be****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Ok, will do.