The gradient that was added to the diff is very distracting. I find it
noticeably harder to read diffs now. If the colors are too heavy why not
just lighten them?
As best as I can recall the colors used in the old version are the colors
that the gradient starts off as. I think the end colors in the gradient
would satisfy Juan's request (which I agree with).
Here's the corresponding changelog entry:
r586 | trowbrds | 2007-05-24 11:02:33 -0700 (Thu, 24 May 2007) | 8 lines
Make colors in diffviewer more subtle. One of the comments that Juan made
on his first look at reviewboard was that the colors in our diff viewer
were a bit too heavy. This basically adds gradient backgrounds to the tops
of change sections that fade to a much lighter color, making large blocks
less fatiguing to read.
Reviewed at http://reviewboard.chipx86.com/r/26/