698: diff time warning could be more specific about the repository

Chris******@actia***** (Google Code) (Is this you? Claim this profile.)
Aug. 26, 2009 
What's the URL of the page this enhancement relates to, if any?
http://reviews.review-board.org/r/598/diff/#index_header (when the diff is 
applied)

Describe the enhancement and the motivation for it.

When a diff takes a "long time" the log (either apache or runserver stdout) 
log has:

`WARNING:root:Generating diff file info for diffset id 21 took 6.44095 
seconds`

This doesn't make the repository information obvious (presumbly you can 
navigate the manage shell and find out), i.e. which repository took so 
long, fore view sites with different repositories this is a minor pain.

What operating system are you using? What browser?
Linux and Windows for server, firefox and Chrome for browser

Please provide any additional information below.
Logged as an enhancement rather than a bug is the information is useful 
(even if not immediately obvious).
chipx86
#1 chipx86
  • +Confirmed
  • -Priority-Medium
    +Priority-Low
    +Component-DiffViewer
    +Logging
    +Milestone-Release1.0
chipx86
#2 chipx86 
Nice to have, but not critical for 1.0.
  • -Milestone-Release1.0
    +Milestone-Release1.5
david
#3 david 
This is actually unimportant. The diff file info step is separate from the
repository. If the repository is being slow, you'll see warnings about "Fetching file
..." which do include the repository.
  • -Confirmed
    +WontFix