687: Can't edit change description

cuv****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Oct. 15, 2008
What's the URL of the page containing the problem?
/r/<id>/

What steps will reproduce the problem?
1. Publish a review
2. Change a field and hit enter to save it
3. Try to enter a change description

What is the expected output? What do you see instead?
The change description field appears, but it is not editable.  There's no
pencil icon, and the field itself is just an empty <pre></pre>

What operating system are you using? What browser?
Firefox 3 and IE6 behave the same.

Please provide any additional information below.

I noticed this snippet in the templates/reviews/review_detail.html:

264 {% if entry.changedesc %}
265   registerEditor('changedescription', true, true);
266 {% endif %}

If I don't have a changedesc yet, then this field doesn't get registered as
an editor.  Later the draft-banner will get shown, but this field is still
just a <pre>.

I think either the conditional code above needs to be called always, or
else showDraftBanner needs to enable changedescription when it's called.
chipx86
#1 chipx86
Should be fixed now in r1535.
  • +Fixed
  • -Priority-Medium
    +Priority-High
    +Component-Reviews
    +Milestone-Release1.0
  • +chipx86