679: Update ReviewBoard to be compatible with official Perforce P4Python API
- NotABug
- Review Board
| ciao****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Oct. 3, 2008 |
ReviewBoard just released it's first officially supported P4Python API (2008.1). Release notes here: http://www.perforce.com/perforce/doc.current/user/p4pythonnotes.txt The new API is different then the old unofficial P4Python API. ReviewBoard needs source changes to support the new official API. The first glaring difference is that "import p4" is now "import P4" (notice the case difference.)
Review Board has used the new API (which was actually introduced in 2007.3) for a few months. Are there specific problems you've encountered?
-
+ NeedInfo
It looks like ReviewBoard is using the Public Depot version rather than official
release that just came out. See the release notes item #7:
7. Compatibility with the P4Python from the Public Depot
Perforce P4Python is significantly different from the version of
P4Python in the Perforce Public Depot. Perforce P4Python
contains several improvements and interface changes
intended to make P4Python consistent with the other scripting
interfaces and with Python in general.
If you are migrating from Public Depot version of P4Python, edit your
scripts to ensure that the scripts comply with the new
interface. The differences are detailed below.
The reason I think this is important is because the 2008.1 version fixes a major
memory leak in p4python (according to the release notes.) The API is different and I
don't think RB can pick up the new API. (for one sources have 'import p4') I could
be mistaken, but this was my interpretation of the release notes.
I updated my code and the older references are no longer in the code. (I still have one reference to 'import p4' but it is in a module I modified, doh!)
-
- NeedInfo + NotABug