673: Diff for text file can be lost following binary diff

cla****@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 15, 2008 
What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Prepare a P4 change that adds a binary file followed by a new text file.  
Open both as text type.
2. Upload the diff.  Bytes in the binary file confuse the diff parser so it 
includes the text file's contents in the binary file's diff section; the 
text file is also not shown in the list of files changed.
3. Change the filetype of the binary file to ubinary and re-post the diff.  
The result is unchanged.

What is the expected output? What do you see instead?


What operating system are you using? What browser?
Chrome on 2003x64; shows up in all browsers.

Please provide any additional information below.
chipx86
#1 chipx86 
Binary data should never appear in a diff. This sounds like a server configuration issue.

Is this at VMware or elsewhere? Can you provide a sample diff (using dummy files so
there's no confidential content) that we can look at?
  • +NeedInfo
david
#2 david 
Closing out because the needed information has not been supplied. If this is still a
problem and you can provide the requested information, please add a comment and I'll
reopen the bug.
  • -NeedInfo
    +Incomplete