672: Reviewers (Groups/People) cannot be edited on draft
- NotABug
- Review Board
| damien******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Sept. 30, 2008 |
What's the URL of the page containing the problem? http://reviewboard.eng.vmware.com/r/xxxxx/ (review request draft page) What steps will reproduce the problem? 1. post-review xxxxxx 2. open draft (step1 gives a http link) 3. groups/people cannot be edited, review cannot be published What is the expected output? What do you see instead? This is a regression, it used to work. Groups/People should have editable fields. What operating system are you using? What browser? win xp, firefox 3 Please provide any additional information below. This is a regression.
You got automatically logged out. Click the "Login" link at the top right of the page.
-
+ UserError
note: why would you assume I got logged out? - If I was not logged in I would not be able to see the draft. - you cannot see someone else's *draft*. - I had doubled checked I was logged in. - I can edit description/title/testing done...etc -> this is a regression Please reopen.
This is bizarre. We haven't changed the code running on reviewboard.eng in quite some time. What happens if you shift+reload on the page?
-
- UserError + New
Damien: 99% of the time when we see this bug, it's due to someone being logged out after viewing the draft (due to Django's default 2 week timeout for cookies expiring at just the wrong time -- which will be fixed in the next upgrade). Hence the assumption that you were logged out.
-
+ Component-Reviews
The green banner is still there. When I reload the page, it just updates the "Updated xxx ago" label right under the "pending review" label. Maybe someone changed a template putting the fields as non-editable. same thing if I logout / login again.
We need to see JavaScript output. Either Firefox's JavaScript console or, preferably, the console from Firebug, if you can install that extension.
Error: YAHOO.widget.DS_XHR is not a constructor Source File: http://reviewboard.eng.vmware.com/media/rb/scripts/reviews.js Line: 94 others are warnings Warning: Error in parsing value for property 'white-space'. Declaration dropped. Source File: http://reviewboard.eng.vmware.com/media/rb/css/diffviewer.css Line: 33 Warning: Unknown property 'word-wrap'. Declaration dropped. Source File: http://reviewboard.eng.vmware.com/media/rb/css/diffviewer.css Line: 35 Warning: Unknown property 'text-overflow'. Declaration dropped. Source File: http://reviewboard.eng.vmware.com/media/rb/css/diffviewer.css Line: 129 Warning: Error in parsing value for property 'filter'. Declaration dropped. Source File: http://reviewboard.eng.vmware.com/media/rb/css/yui-ui.css Line: 26 Warning: Error in parsing value for property 'left'. Declaration dropped. Source File: http://reviewboard.eng.vmware.com/media/rb/css/yui-ui.css Line: 42
Alright, so for whatever reason your YAHOO.widget.DS_XHR function is not being seen or is mangled in some way. I'd suggest clearing your cache and going back. We have not changed anything in months and this is working for other people with Firefox 3.
it is working after the cache has been cleared. thanks.
-
- New + NotABug