666: view diff causes Error - cvs.py

drg***@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
March 24, 2009 
What's the URL of the page containing the problem?
.../r/7/diff/#index_header

What steps will reproduce the problem?
1. Generate a diff from CVS 2.0.51d 
2. Post a new review request
3. Reviewer tries to view diff 

What is the expected output? What do you see instead?

What i expect : To see the diff
What i get :
close_fds is not supported on Windows platforms

Traceback (most recent call last):
  File "D:\reviewboard\diffviewer\views.py", line 86, in view_diff
    files = get_diff_files(diffset, None, interdiffset, highlighting)
  File "D:\reviewboard\diffviewer\diffutils.py", line 651, in get_diff_files
    enable_syntax_highlighting)
  File "D:\reviewboard\diffviewer\diffutils.py", line 567, in generate_files
    lambda: get_chunks(filediff.diffset,
  File "D:\reviewboard\djblets\util\misc.py", line 55, in cache_memoize
    data = lookup_callable()
  File "D:\reviewboard\diffviewer\diffutils.py", line 570, in <lambda>
    enable_syntax_highlighting))
  File "D:\reviewboard\diffviewer\diffutils.py", line 337, in get_chunks
    old = get_original_file(filediff)
  File "D:\reviewboard\diffviewer\diffutils.py", line 244, in 
get_original_file
    data = cache_memoize(key, lambda: [fetch_file(file, revision)])[0]
  File "D:\reviewboard\djblets\util\misc.py", line 55, in cache_memoize
    data = lookup_callable()
  File "D:\reviewboard\diffviewer\diffutils.py", line 244, in <lambda>
    data = cache_memoize(key, lambda: [fetch_file(file, revision)])[0]
  File "D:\reviewboard\diffviewer\diffutils.py", line 224, in fetch_file
    data = tool.get_file(file, revision)
  File "D:\reviewboard\scmtools\cvs.py", line 59, in get_file
    return self.client.cat_file(path, revision)
  File "D:\reviewboard\scmtools\cvs.py", line 163, in cat_file
    close_fds=True)
  File "C:\Python25\lib\subprocess.py", line 552, in __init__
    raise ValueError("close_fds is not supported on Windows "
ValueError: close_fds is not supported on Windows platforms


What operating system are you using? What browser?

Review board on 
  Windows XP
  MySQL 5.60
Browsers used 
  IE 6.0/Opera 9.5

Please provide any additional information below.
chipx86
#1 chipx86 
What version of Python are you using?
  • +NeedInfo
chipx86
#2 chipx86
  • +OpSys-Windows
    +Component-DiffViewer
#3 drg***@gmai***** (Google Code) (Is this you? Claim this profile.) 
The following are the versions of different sw used.

Python version : Python 2.5.2
Django version 1.0
patch-2.5.9-7
PIL-1.1.6
#4 drg***@gmai***** (Google Code) (Is this you? Claim this profile.) 
Is there any way we need to change the stuatus as "assigned " or "info supplied" ?
I do not see any way to effect such a change ?
TIA.
drgiri
david
#5 david 
It's something the group admins have access to, but isn't open to regular users.
  • -NeedInfo
    +Accepted
  • +chipx86
david
#6 david
  • -Accepted
    +Confirmed
#7 onkar******@gmai***** (Google Code) (Is this you? Claim this profile.) 
I saw same problem on my Ubuntu machine. The cause was that cvs was not installed.
See of that is the problem in your case. Check if cvs binary is in path on your
Windows machine.
#8 drg***@gmai***** (Google Code) (Is this you? Claim this profile.) 
I use a different server (different physical machine) for hosting CVS repositories.
I have supplied the authentication informtion (:pserver....) as a connection.

As i realialize, the diff will be viewed through a client machine while review board 
runs on a server. What do i need to install on the client machines ?
chipx86
#9 chipx86 
Clients don't need anything special to view diffs. All the access and rendering is
done from the server. As long as the Review Board server can see the CVS server, your
users should be able to see the diff.
#10 onkar******@gmai***** (Google Code) (Is this you? Claim this profile.) 
@drgiri,

On the review board server you need to have cvs client installed so that review board
can retrieve the information using the client.
david
#11 david 
Fixed in revision 1849. Thanks!
  • -Confirmed
    +Fixed