665: Link to diff between revisions is broken

cas****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 4, 2009
What's the URL of the page containing the problem?

http://maki/r/25/diff/1/#index_header


What steps will reproduce the problem?
1. Add two revisions to a single review
2. Jump to the first revision
3. Click on changes between r1 and 2

The link associated to the last action seems to be wrong:

http://maki/r/25/diff/[23]%20diff%20r1-None/#index_header


What is the expected output? What do you see instead?

I expect the link should be:

http://maki/r/25/diff/1-2/#index_header


What operating system are you using? What browser?

WinXP/Google chrome


Please provide any additional information below.
chipx86
#1 chipx86
  • +Confirmed
  • +Component-DiffViewer
    +Interdiffs
chipx86
#2 chipx86
This should be fixed now.
  • -Confirmed
    +Fixed