660: RFE: Eclipse plugin for ReviewBoard
- Fixed
- Review Board
| kevin.******@beatpo****** (Google Code) (Is this you? Claim this profile.) | |
| Sept. 2, 2009 |
It would really be helpful if I had a MyLyn extension that would interact with ReviewBoard to help me know when I have reviews to do and help me get through the review process more easily. It would also help if I could submit new reviews directly from Eclipse without having to leave the UI. In my case, I'm a windows-based user, though I often use Linux as well. In either case, my browser preference is Firefox.
This is definitely something we want as well, though we won't have time to do it here. I'm hoping if nobody else does it that next summer we can get a student from Google's Summer of Code to work on one.
-
- Type-Defect + Type-Enhancement + Component-Integration
We have the same problem. We'd love it if we could have the same integration as SVN+Eclipse (Subversive). Right now, ctrl-alt-c on a folder creates a new commit dialog for all files in and below that top-level folder. It allows you to enter descriptions and select which files you want to include in the commit. It's awesome, and could probably be duplicated nearly verbatim if you can still use post-review.py as the back-end: http://dev.eclipse.org/svnroot/technology/org.eclipse.subversive/ Here's our crude solution that works moderately well in WindowsXP. It automates the review submission, but doesn't allow you to select individual files or add descriptions/testing from eclipse. post-review.bat ~~~~~ @echo off cls SET ReviewNum="" SET ProjectsToCheck=. SET Reviewers= cd %~dp0 cd .. REM Get our list of reviewers based on who is logged in (winXP) IF NOT %USERNAME%==firstname1.lastname1 SET Reviewers=%Reviewers%firstname1.lastname1 IF NOT %USERNAME%==firstname2.lastname2 SET Reviewers=%Reviewers%firstname2.lastname2 IF NOT %USERNAME%==firstname3.lastname3 SET Reviewers=%Reviewers%firstname3.lastname3 REM This is a list of all externals we check for in a review submission IF EXIST ./external1 SET ProjectsToCheck=%ProjectsToCheck% external1 IF EXIST ./external2 SET ProjectsToCheck=%ProjectsToCheck% external2 IF EXIST ./external3 SET ProjectsToCheck=%ProjectsToCheck% external3 :needReviewNumber SET /P ReviewNum="Review Board Review Number: (press enter for new): ": IF %ReviewNum% == "" GOTO newReview IF /i %ReviewNum% leq 0 GOTO needReviewNumber IF /i %ReviewNum% geq 10000 GOTO needReviewNumber :existingReview python ./reviewboard/post-review.py %ProjectsToCheck% --target-people=%Reviewers% -o -r %ReviewNum% GOTO END :newReview python ./reviewboard/post-review.py %ProjectsToCheck% --target-people=%Reviewers% -o GOTO END :END echo Done! REM Ghetto way to get a sleep in windows xp ping 127.0.0.1 -n 4 >nul
There I go posting without thinking again. The directory structure is as follows: The top level project includes any number of externals, which have to be included manually in the batch script. This is because svn diff doesn't diff externals by default. The batch script is in a directory that's included as an external resource, reviewboard, in the following example: /toplevelproject/reviewboard/post-review.bat /toplevelproject/reviewboard/post-review.py
Hello! If you haven't read it, I'm a student participation in the Google Summer of Code and my projects is basically this ticket. I have a first version of the Eclipse plugin ready. Here is the update site: http://www.knittig.de/temp/updateSite/ Needs Eclipse 3.5 and Mylyn 3.2. This version is obviously not stable, so feedback about problems and improvements would be appreciated.
Looks like I need some documentation. I assumed people how test this know Mylyn. But I just got mail which tells me otherwise. I also finally set up a repository. It's located here: http://github.com/mknittig/ereviewboard The new update site is here: http://www.knittig.de/ereviewboard/update
I think at this point, the eclipse plugin is a living entity, so I'm going to close this out.
-
+ Fixed