652: Mails are not sent when user is in the CC

dimitar********@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Sept. 18, 2008 
What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Post New Request.
2. The reviewer goes in TO and you as review requester go to the CC field.
3. Reviewer receive e-mail but requester is not getting e-mail. This
happens even when the code is reviewed and/or ready to be shipped. Then the
reviewer publish his comments and "Ship it" flag and post the review. You
will not be notified that your code is reviewed because you will be in the
CC field.

What is the expected output? What do you see instead?
E-mails to users in CC should be received.

What operating system are you using? What browser?
Fedora Core 9/Mozilla Firefox

Please provide any additional information below.
email.diff 
Index: email.py
===================================================================
--- email.py	(revision 1500)
+++ email.py	(working copy)
@@ -30,7 +30,7 @@
 
 class SpiffyEmailMessage(EmailMessage):
     def __init__(self, subject, body, from_email, to, cc, in_reply_to):
-        EmailMessage.__init__(self, subject, body, from_email, to)
+        EmailMessage.__init__(self, subject, body, from_email, to, cc)
 
         self.cc = cc or []
chipx86
#1 chipx86 
That patch will add to the BCC list. We need to find out why CC is failing.

On the e-mails, are you actually seeing the right e-mail addresses on the "Cc" line?
Can you provide the e-mail headers for one of those e-mails? (Feel free to mask the
domain names or other sensitive info).
  • +NeedInfo
  • -Priority-Medium
    +Priority-Critical
    +Component-EMail
chipx86
#2 chipx86 
Looks like this was due to not including the CC users in the recipient list that goes
out to sendmail. It should be fixed in r1509. Please let me know if it continues to
be a problem.
  • -NeedInfo
    +Fixed
  • +chipx86
#3 dimitar********@gmai***** (Google Code) (Is this you? Claim this profile.) 
With your last commit(r1509) it looks fixed. So I don't have to attach you e-mail
headers as you request. Just to comment that CC was in the e-mail, but no e-mail is
sent to the CC recipient. I now that my fix goes to BCC but I needed a fast working
patch.

Anyway now I can confirm that with r1509 it works for me.

Thanks,
    Dimitar