645: post-review.py: handle_renames incorrectly mangles '-->' lines for SVN

jhar*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 28, 2008 
post-review.py

1. edit an XML file in SVN containing comments like this:
<!--
-->
   remove the comments with an editor.

2. use post-review.py to post the file.

3. In the resulting review, use the "View Diffs" button.  The server
displays an error.  The error is because the diff posted by the
post-review.py script is corrupt.  The diff is corrupt because the method
"handle_renames" mangles the "-->" string and eliminates it because it is
looking indiscriminately for the string "---" in the diff.

What operating system are you using? What browser?
Windows to post, Linux to run server with Firefox.
chipx86
#1 chipx86
  • +Accepted
  • -Priority-Medium
    +Priority-Critical
    +Milestone-Release1.0
    +Component-Scripts
#2 jhar*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
The reviewboard server should validate its inputs more carefully.  For example, the
diffs being posted should be checked for correctness to prevent an error from
occurring later on (a corrupt data issue).
david
#3 david
  • -Accepted
    +New
david
#4 david 
Fixed in SVN r1645.
  • -New
    +Fixed