642: post-review: diff containing xml causes 500 internal server error

z.ca****@f5.*** (Google Code) (Is this you? Claim this profile.)
Sept. 11, 2008 
What's the URL of the page containing the problem?

Unable to access
https://reviewboard.olympus.f5net.com/api/json/reviewrequests/851/update_from_changenum/.
The host path may be invalid
HTTP Error 500: Internal Server Error


What steps will reproduce the problem?
1. create a changeset with xml in the diff
2. post-review <changeset>
3.

What is the expected output? 

review posted url

What do you see instead?

See above error


What operating system are you using? What browser?

Linux, firefox


Please provide any additional information below.
chipx86
#1 chipx86 
Can you pass --debug to post-review and attach the output as a .html file? (make sure
to sanitize it first so any internal info isn't revealed).
  • +NeedInfo
  • +Component-DiffParser
    +Milestone-Release1.0
#2 z.ca****@f5.*** (Google Code) (Is this you? Claim this profile.) 
attaching --debug output
  • +
    post-review-debug.html 
    >>> Repository info 'Path: caspian.olympus.f5net.com:1666, Base path: None, Supports changesets: True'
    >>> Generating diff for changenum 591517
    >>> Processing edit of //depot/project/parkcity/xui/production/modules/LocalTraffic/module.xml
    >>> Writing "//depot/project/parkcity/xui/production/modules/LocalTraffic/module.xml#8" to "/tmp/tmpWI1Lm9"
    >>> Looking for 'reviewboard.olympus.f5net.com /' cookie in /home/reichenbach/.post-review-cookies.txt
    >>> Cookie file loaded, but no cookie for this server
    ==> Review Board Login Required
    Enter username and password for Review Board at https://reviewboard.olympus.f5net.com/
    Username: Password: 
    >>> Logging in with username "reichenbach"
    >>> Logging in with password "*******"
    >>> HTTP POSTing to https://reviewboard.olympus.f5net.com/api/json/accounts/login/: {'username': 'reichenbach', 'password': '**************'}
    >>> Logged in.
    >>> Attempting to create review request for 591517
    >>> Create review request
    >>> {'repository_path': 'caspian.olympus
chipx86
#3 chipx86 
The problem is that the summary text (first line of the change description) is too
long. This has been fixed in SVN, so if you upgrade (and you'll need Django 1.0 as
well) this problem should go away. A quick fix in this case though is to shorten the
first line of your change description, limiting it to the first sentence, and putting
additional data on separate lines. You'll need a blank line after the first line, though.
  • -NeedInfo
    +Fixed
chipx86
#4 chipx86 
Dup of bug 515.
  • -Fixed
    +Duplicate