630: Cannot navigate to diffs when changelist is only for files removal.

gp1***@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 15, 2008
What's the URL of the page containing the problem?
https://reviewboard-qa.eng.vmware.com/r/3141/diff/#index_header

What steps will reproduce the problem?
1. I am trying to navigate to the diff page at above URL
2.
3.

What is the expected output? What do you see instead?
Instead of diffs I see the output posted at the end of the comment.

What operating system are you using? What browser?


Please provide any additional information below.
 


The patch to '<none>' didn't apply cleanly. The temporary files have been
left in '/tmp/reviewboard.OkHl_D' for debugging purposes. `patch` returned:
patching file /tmp/reviewboard.OkHl_D/tmpL1hHmZ

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/reviewboard/diffviewer/views.py",
line 82, in view_diff
    files = get_diff_files(diffset, None, interdiffset, highlighting)
  File
"/usr/lib/python2.4/site-packages/reviewboard/diffviewer/diffutils.py",
line 561, in get_diff_files
    enable_syntax_highlighting)
  File
"/usr/lib/python2.4/site-packages/reviewboard/diffviewer/diffutils.py",
line 500, in generate_files
    lambda: get_chunks(filediff.diffset,
  File "/usr/lib/python2.4/site-packages/djblets/util/misc.py", line 47, in
cache_memoize
    data = lookup_callable()
  File
"/usr/lib/python2.4/site-packages/reviewboard/diffviewer/diffutils.py",
line 503, in <lambda>
    enable_syntax_highlighting))
  File
"/usr/lib/python2.4/site-packages/reviewboard/diffviewer/diffutils.py",
line 299, in get_chunks
    new = get_patched_file(old, filediff)
  File
"/usr/lib/python2.4/site-packages/reviewboard/diffviewer/diffutils.py",
line 212, in get_patched_file
    return patch(filediff.diff, buffer, filediff.dest_file)
  File
"/usr/lib/python2.4/site-packages/reviewboard/diffviewer/diffutils.py",
line 107, in patch
    raise Exception(_("The patch to '%s' didn't apply cleanly. The
temporary " +
Exception: The patch to '<none>' didn't apply cleanly. The temporary files
have been left in '/tmp/reviewboard.OkHl_D' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.OkHl_D/tmpL1hHmZ
chipx86
#1 chipx86
How did you generate the diff and upload it? Via post-review, p4 diff, or p5 diff?
  • +NeedInfo
  • +VMware
    +Component-DiffViewer
david
#2 david
Closing out because the needed information has not been supplied. If this is still a
problem and you can provide the requested information, please add a comment and I'll
reopen the bug.
  • -NeedInfo
    +Incomplete
#3 gp1***@gmai***** (Google Code) (Is this you? Claim this profile.)
I generated the diff with p5 diff.
Uploaded it through the web page.
With the same procedure right after this I created another review which has no problems.