627: post-review: show debugging output even before options are parsed, if enabled in-source

timw.a******@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 4, 2008 
When patching post-review, I noticed some debugging output wouldn't show
up. It turns out that until the command-line options are parsed, it
operates in no-debug mode.

This patch additionally checks the in-source global flag.
postreview-debug.patch 
Index: contrib/tools/post-review
===================================================================
--- contrib/tools/post-review	(revision 1477)
+++ contrib/tools/post-review	(working copy)
@@ -1218,7 +1218,7 @@
     """
     Prints debugging information if post-review was run with --debug
     """
-    if options and options.debug:
+    if DEBUG or options and options.debug:
         print ">>> %s" % s
chipx86
#1 chipx86 
Thanks for the patch. Can you please put it up on http://reviews.review-board.org/ ?
We'll review it there.
  • +Component-Scripts
david
#2 david 
Fixed in SVN r1481. Thanks!
  • +Fixed