624: Can't add inline comments from diff view "discussion" tab
- Fixed
- Review Board
| sam****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
 |
|
| Dec. 27, 2008 |
What's the URL of the page containing the problem? What steps will reproduce the problem? 1. Create a review from the "diff view" page, publish the review 2. The new review thread appears on the review request page. You can add inline comments in response to that review, but only from the review request page 3. If you're looking through the "diff view" page, and click on a discussion (marked with #comments near a line number), a window pops up. Click on discussion tab. 4. In the discussion tab, there is no way to add an inline comment in response to an existing review. You can only create a new review of the line/lines, and publish it. What is the expected output? What do you see instead? It would be really neat if there was an "Add comment" button in the "discussion" tab that allowed you to respond to that particular review. Right now you can only do that from the review request page. What operating system are you using? What browser? WinXP/Firefox 3.0 Please provide any additional information below.
I believe this is a dup of another bug but I haven't really looked for it yet. Review Board internally isn't structured to let you work on more than one "review" (and replies to a review count internally as a "review") at a time, so this functionality just isn't possible yet. Whether we add it down the road or not, I don't know. I think there's other things to consider before we can answer this.
-
- Priority-Medium + Priority-Low + Component-DiffViewer + Component-Reviews
My UI rewrite makes it a little more clear how to respond to a comment, which should in a way satisfy this bug. Essentially, existing comments will have "Reply" links, which will let you reply to that comment. It's more clear that a new comment is in fact a new comment and not a reply.
-
+ Started -
+ chipx86
I have several comments about this workflow, which is confusing a lot of people. First, I don't think there should be a "Review" and "Discussion" tab in the dialog that you get when you click on a line in the diff. That's too complicated. And that "Review" link hidden next to the patch link is almost impossible to see. The diff page should detect changes like the request page does and offer Publish/Discard buttons at the top in the same way, and the Publish button should bring up the equivalent of today's "Review" tab, allowing for an overall comment and ticking of the "Ship It" checkbox. Finally, it should be possible to start multiple conversations on a single line, and have reply threads for each of them. And I think you should be able to add to those threads without leaving the diff view. Thanks!
The entire existing design of this is going away so the first and second don't apply anymore. With the third, it will take some time until we get this functionality added the way I'd like. For now, each existing comment will have a Reply link which will take you to the review request page and add a comment field under the comment you wish to reply do. Down the road we can expand on this.
This is much better and less confusing in r1644. Further improvements will be made in future changes.
-
- Started + Fixed
Is there a new open issue for the enhancement of the third item request? "Finally, it should be possible to start multiple conversations on a single line, and have reply threads for each of them. And I think you should be able to add to those threads without leaving the diff view." We are having new developers not realize they are not threading comments when they attempt to reply an original review comment.