What's the URL of the page containing the problem?
Server's behind a firewall. Problem is visible when clicking "View Diff" from
a review, or viewing changes between diff r1 & r2 under conditions described
below
What steps will reproduce the problem?
1. Create a new review with a diff "test.diff" generated from trunk/dir1.
test.diff contains changes to the file trunk/dir1/subdir/file.c
2. Make further changes to file.c or another file in subdir.
3. Create a new diff "test2.diff" via "svn diff" -- create this diff from
trunk/dir1/subdir. The base diff base (/trunk/dir1) is different from the base
path of the new patch. When attaching the new diff, put /trunk/dir1/subdir as
base path
What is the expected output? What do you see instead?
Expecting "View Diff" to show the new diff, and also to be able to view
changes between test.diff (r1) and test2.diff (r2). Instead, review board
throws a long complicated traceback of errors.
I would expect that when uploading the new diff (test2.diff), review board
would detect that the base path is different and either a) reject the patch,
force me to re-create it from trunk/dir1 OR 2) notice that the repo + base
path + diff file still points to a valid change set, and everything functions
normally.
What operating system are you using? What browser?
WinXP, Firefox 3.0
Please provide any additional information below.
Excellent job on review board, I love this tool and can't wait to see how it
matures. Everyone should be using this tool.
