622: post-review: Should check that default changelist is empty

nithi******@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 28, 2008 
Describe the enhancement and the motivation for it.
Many a times, a developer will submit a changelist that has a couple of
files missing and break the build. They will have been forgotten in the
default changelist.

If post-review can fail with a message like that, these mistakes can be
avoided.
chipx86
#1 chipx86 
Many developers keep several concurrent changesets in their tree and having something
in "default" isn't really wrong. Maybe we could warn about it if it's in "default"
but I'm not sure yet whether that'll end up being more useful than annoying. I'll
think about it some more.
  • -Type-Defect
    +Type-Enhancement
    +Component-Scripts
david
#2 david 
I think while this might be useful to some, most developers I know work with multiple
simultaneous changesets (or, at the very least, keep a distinction between their
working changeset and default). I'm going to put my foot down and suggest this would
be annoying.
  • +WontFix